Skip to content

Capitalize Client in "client modules" #6419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

Capitalize Client in "client modules" #6419

merged 1 commit into from
Nov 7, 2023

Conversation

Huxpro
Copy link
Member

@Huxpro Huxpro commented Nov 7, 2023 •
edited
Loading

Summary of changes:
See #6417.

Alternatively, we can follow the current Next.js doc and use "Client Component modules". However, considering the possible existence of React Client Action, it seems like this notion does not necessarily bound to "Component".

How do we call this:

// requestUsername.js
'use server';

export default async function requestUsername(formData) {
  const username = formData.get('username');
  if (canRequest(username)) {
    // ...
    return 'successful';
  }
  return 'failed';
}
  • Server module?
  • Server Action module?
  • Server Module??

@Huxpro Huxpro requested a review from gaearon November 7, 2023 12:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@gaearon gaearon merged commit c5a2e15 into main Nov 7, 2023
@rickhanlonii rickhanlonii deleted the xuan/capClientModule branch April 29, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Huxpro @gaearon @facebook-github-bot